Skip to content

[SYCL] Enable standard optimization pipeline for device code #2207

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2020
Merged

[SYCL] Enable standard optimization pipeline for device code #2207

merged 4 commits into from
Aug 5, 2020

Conversation

bader
Copy link
Contributor

@bader bader commented Jul 29, 2020 •
edited
Loading

Add new compiler flag to disable optimizations at compile time:
-fno-sycl-std-optimizations

Temporally disable optimizations in some LIT tests.

@bader
Copy link
Contributor Author

bader commented Jul 29, 2020

/summary:run

1 similar comment
@bader
Copy link
Contributor Author

bader commented Jul 30, 2020

/summary:run

@bader bader added the performance Performance related issues label Jul 30, 2020
@bader
Copy link
Contributor Author

bader commented Jul 30, 2020

/summary:run

@bader
Copy link
Contributor Author

bader commented Aug 4, 2020

I'd like to commit this patch ASAP to avoid regressions in the future.
There are still a few issues with enabling standard optimization pipeline for SPIR target, but I'll handle them post-commit.
I'm going to introduce a new compiler flag to rollback to old behavior when needed (e.g. -fno-sycl-optimizations).

Let me now if you have any concerns about that plan.

@bader
[SYCL] Enable standard optimization pipeline for device code by default
0909cfb 
Add new compiler flag to disable optimizations at compile time:
 -fno-sycl-std-optimizations

 Temporally disable optimizations in some LIT tests.
@bader bader force-pushed the test-optimizations branch from 54bdb93 to 0909cfb Compare August 4, 2020 18:53
@bader bader marked this pull request as ready for review August 4, 2020 18:54
@bader bader requested a review from rbegam August 4, 2020 18:54
@bader bader changed the title [WIP][SYCL] Enable standard optimization pipeline for device code [SYCL] Enable standard optimization pipeline for device code Aug 4, 2020
premanandrao
premanandrao previously approved these changes Aug 4, 2020
View reviewed changes
@bader bader requested review from mdtoguchi and premanandrao August 4, 2020 19:49
mdtoguchi
mdtoguchi previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

premanandrao
premanandrao previously approved these changes Aug 4, 2020
View reviewed changes
@elizabethandrews
Copy link
Contributor

LGTM except for one question - Should a comment be added to the 2 tests where optimizations were enabled before and now disabled, since this is a temporary change?

@bader
Copy link
Contributor Author

bader commented Aug 4, 2020

LGTM except for one question - Should a comment be added to the 2 tests where optimizations were enabled before and now disabled, since this is a temporary change?

I'll open an issue to update all the tests where optimizations were disabled due to different issues (there are more than 2 tests) and add a comment with issue ID to all the tests.

Fznamznon
Fznamznon previously approved these changes Aug 5, 2020
View reviewed changes
@bader bader mentioned this pull request Aug 5, 2020
Closed
@bader bader dismissed stale reviews from Fznamznon, premanandrao, and mdtoguchi via d5ff978 August 5, 2020 10:49
@bader bader mentioned this pull request Aug 5, 2020
Merged
@pvchupin pvchupin merged commit 5976ff0 into intel:sycl Aug 5, 2020
@bader bader deleted the test-optimizations branch September 10, 2020 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Fznamznon Fznamznon Fznamznon left review comments

@premanandrao premanandrao premanandrao left review comments

@mdtoguchi mdtoguchi mdtoguchi left review comments

@elizabethandrews elizabethandrews elizabethandrews left review comments

@AGindinson AGindinson Awaiting requested review from AGindinson

@rbegam rbegam Awaiting requested review from rbegam

Assignees
No one assigned
Labels
performance Performance related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bader @elizabethandrews @Fznamznon @premanandrao @mdtoguchi @pvchupin