-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Add identification macro for DPCPP compiler #2998
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
triple in test Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the assumption that we don't need the feature-testing components because it will be handled through other means, this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the review @AaronBallman
Thanks @AaronBallman and @premanandrao! @pvchupin is there a known failure with pre-commit testing? There is a stream test failing. I do not know how this change can cause it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss more on this macro first.
Any updates on this? |
After an offline discussion with @pvchupin and others, a decision was made to not support any additional macros at the moment. SYCL_LANGUAGE_VERSION can be used to identify any SYCL compiler. |
Add predefined macro __DPCPP_COMPILER = 1, to uniquely identify DPCPP compiler.
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com