[SYCL] Support unnamed lambda kernels #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for kernels without kernel name. Requires compiling with -DUNNAMED_LAMBDA_EXT. Uses new __unique_stable_name compiler built-in. Signed-off-by: Roland Schulz <roland.schulz@intel.com> Signed-off-by: Alexey Bader <alexey.bader@intel.com>
mlychkov
reviewed
Jul 25, 2019
MrSidims
reviewed
Jul 25, 2019
Ruyk
reviewed
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
User activates the extension with the new flag rather than previously with -DUNNAMED_LAMBDA_EXT. Fixes that the err_sycl_kernel_name_class_not_top_level is an error without the extension and not a warning with it. Only the version of the integration header needed is generated (rather than both version with #ifdef). Defines __SYCL_UNNAMED_LAMBDA__ when extension is active. Signed-off-by: Roland Schulz <roland.schulz@intel.com>
vladimirlaz
approved these changes
Jul 30, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for kernels without kernel name. Requires compiling
with -DUNNAMED_LAMBDA_EXT. Uses new __unique_stable_name
compiler built-in.