-
Notifications
You must be signed in to change notification settings - Fork 770
[WIP][SYCL][LevelZero] Force reset of memcpy command-list #3941
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that spelling in comment, LGTM
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smaslov-intel, are the fails related to the change? |
@kbsmith-intel, @pvchupin : I was able to reproduce the hang in https://github.com/intel/llvm-test-suite/blob/intel/SYCL/InorderQueue/in_order_usm_explicit.cpp. There are 3 memcpy submitted into the in-order queue there (all in there own command-lists) and synchronizing the last memcpy's event never finishes. Nothing jumped out at me by just looking at traces, needs debugging. I consider this being of low priority (and may be even drop it altogether) since a L0 driver complete fix is ready. |
If that was a workaround and real fix is ready feel free to abandon the change, unless @kbsmith-intel see any value I'm missing... |
merged in #4001 |
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com