[SYCL] Add support for SYCL_EXTERNAL #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndmitriev
requested review from
bader,
Fznamznon,
erichkeane,
asavonic and
AlexeySachkov
Fznamznon
previously approved these changes
Sep 10, 2019
sndmitriev
force-pushed
the
public/sndmitriev/sycl-external-macro
branch
from
1063816 to
37d301b
Compare
kbobrovs
reviewed
Sep 17, 2019
| implicitly inherit this attribute. | ||
| }]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for providing the doc!
All functions annotated by the sycl_device attribute are supposed to be retained in the device compilation as well as the functions that are called/accessed from them. Support for sycl_device attribute was incomplete in clang; this patch adds the missing functionality. Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
sndmitriev
force-pushed
the
public/sndmitriev/sycl-external-macro
branch
from
37d301b to
16eda88
Compare
kbobrovs
approved these changes
Sep 18, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
(a) Completes implementation for sycl_device attribute
(b) Defines SYCL_EXTERNAL macro as prescribed by the spec