Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Analysis framework #2114

Merged
merged 27 commits into from
Feb 12, 2024
Merged

Analysis framework #2114

merged 27 commits into from
Feb 12, 2024

Conversation

0ssigeno
Copy link
Contributor

@0ssigeno 0ssigeno commented Feb 7, 2024

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
@0ssigeno 0ssigeno requested a review from mlodic February 7, 2024 14:14
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

0ssigeno and others added 4 commits February 7, 2024 15:14
# Conflicts:
#	api_app/serializers/job.py
Signed-off-by: 0ssigeno <s.berni@certego.net>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
# Conflicts:
#	api_app/serializers/job.py
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
# Conflicts:
#	api_app/management/commands/dumpplugin.py
#	api_app/playbooks_manager/serializers.py
Signed-off-by: 0ssigeno <s.berni@certego.net>
@0ssigeno 0ssigeno merged commit 0b82cfb into develop Feb 12, 2024
11 of 12 checks passed
@0ssigeno 0ssigeno deleted the analysis_framework branch February 12, 2024 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants