Docinfo oletools #2143
Merged
Docinfo oletools #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| @@ -168,6 +172,25 @@ def analyze_for_follina_cve(self) -> List[str]: | |||
| hits += re.findall(r"mhtml:(https?://.*?)!", target) | |||
| return hits | |||
|
|
|||
| def analyze_for_cve(self) -> Dict: | |||
| pattern = r"CVE-\d{4}-\d{4,7}" | |||
| cve = dict() | |||
There was a problem hiding this comment.
Suggested change
| cve = dict() | |
| cve = {} |
Using dict literal syntax is simpler and computationally quicker. Read more.
0ssigeno
approved these changes
Feb 14, 2024
mlodic
reviewed
Feb 14, 2024
Comment on lines
182
to
192
| if matches := re.findall(pattern, clsid_text): | ||
| for match in matches: | ||
| if match in cve: | ||
| if clsid in cve[match]: | ||
| cve[match][clsid].append(clsid_text) | ||
| cve[match][clsid] = list(set(cve[match][clsid])) # uniq | ||
| else: | ||
| cve[match][clsid] = [clsid_text] | ||
| else: | ||
| cve[match] = {clsid: [clsid_text]} | ||
| return cve |
There was a problem hiding this comment.
I would take all texts where there is at least the "CVE" word, then I would extract the CVE numbers if they are available. In this way you can extract even the cases when the descripion just says "probable related to CVEs..."
mlodic
approved these changes
Mar 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
develop_monkeypatch()was used in its class to apply the necessary decorators.dumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.