-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Frontend - Investigations framework #2197
Conversation
Signed-off-by: 0ssigeno <s.berni@certego.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some little changes in the code, but nothing very relevant. You did a very great work:
- I tested manually all the UI and also the edge cases and everything works
- Good refactor of some components
- Good structure of folders and files
@carellamartina I merged a pr from another contributor, in the pr he created a new component for the cells for the plugin and job tables, this is the reason of the merge conflict. Feel free to ask me the desired UX of the tables cells if you want |
Waiting to better test websocket feature before merging this and add another huge feature to test |
Description
Added analysis structure:
Type of change
Please delete options that are not relevant.
Checklist
develop
_monkeypatch()
was used in its class to apply the necessary decorators.dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.Important Rules