Improve read parameters

api_app/analyzers_manager/migrations/0001_initial_squashed.py

@@ -6,7 +6,6 @@
 import django.utils.timezone
 from django.db import migrations, models
 
-import api_app.defaults
 import api_app.fields
 import api_app.validators
 

api_app/analyzers_manager/observable_analyzers/feodo_tracker.py

@@ -42,14 +42,13 @@ def default_locations(cls) -> Tuple[str, str]:
 
     def run(self):
         result = {"found": False}
-        db_location, url = (
+        db_location, _ = (
             self.recommend_locations
             if self.use_recommended_url
             else self.default_locations
         )
-        if self.update_on_run or not os.path.exists(db_location):
-            if not self.update():
-                raise AnalyzerRunException("Unable to update database")
+        if self.update_on_run or not os.path.exists(db_location) and not self.update():
+            raise AnalyzerRunException("Unable to update database")
         try:
             with open(db_location, "r", encoding="utf-8") as f:
                 db = json.load(f)

api_app/analyzers_manager/observable_analyzers/ip2location.py

@@ -20,10 +20,10 @@ def run(self):
         try:
             payload = {"ip": self.observable_name}
 
-            """ There are two free versions of the service:
-                1. keyless : Requires No API key and has a daily limit of 500 queries
-                2. keyed: Requires API key.
-            """
+            # There are two free versions of the service:
+            #    1. keyless : Requires No API key and has a daily limit of 500 queries
+            #    2. keyed: Requires API key.
+
             if self.api_version == "keyed":
                 payload["key"] = self._api_key_name
 

api_app/analyzers_manager/observable_analyzers/mmdb_server.py

@@ -3,9 +3,6 @@
 import requests
 
 from api_app.analyzers_manager import classes
-from api_app.analyzers_manager.exceptions import (  # AnalyzerConfigurationException
-    AnalyzerRunException,
-)
 from tests.mock_utils import MockUpResponse, if_mock_connections, patch
 
 logger = logging.getLogger(__name__)
@@ -19,16 +16,12 @@ class MmdbServer(classes.ObservableAnalyzer):
     def update(self) -> bool:
         pass
 
-    base_url = str
+    base_url: str
     observable_name: str
 
     def run(self):
-        try:
-            response = requests.get(self.base_url + self.observable_name)
-            response.raise_for_status()
-        except requests.RequestException as e:
-            logger.exception("Error while querying mmdb server: {e}")
-            raise AnalyzerRunException(e)
+        response = requests.get(self.base_url + self.observable_name)
+        response.raise_for_status()
         return response.json()
 
     @classmethod

api_app/analyzers_manager/observable_analyzers/otx.py

@@ -154,7 +154,7 @@ def run(self):
             logger.warning(
                 f"Sections: {not_supported_requested_section_list}"
                 f" are not supported for indicator type: {otx_type}. "
-                f"We remove them from the search."
+                "We remove them from the search."
             )
             for not_supported in not_supported_requested_section_list:
                 self.sections.remove(not_supported)