Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix loading visualizer navbar #2335

Merged
merged 2 commits into from
May 21, 2024
Merged

fix loading visualizer navbar #2335

merged 2 commits into from
May 21, 2024

Conversation

carellamartina
Copy link
Contributor

@carellamartina carellamartina commented May 21, 2024

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • I have added that raw JSON sample to the MockUpResponse of the _monkeypatch() method. This serves us to provide a valid sample for testing.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@carellamartina carellamartina requested a review from drosetti May 21, 2024 08:11
@drosetti drosetti merged commit 2832bec into develop May 21, 2024
12 checks passed
@drosetti drosetti deleted the visualizer_loading branch May 21, 2024 09:03
mlodic added a commit that referenced this pull request May 21, 2024
* updated yeti analyzer and connector to support new major

* updated default pycti version

* fixed MaxMind data extraction for the country flag

* Fix pivot + file

Signed-off-by: 0ssigeno <s.berni@certego.net>

* healthcheck available for Plugins with `url` option by default (#2320)

* healthcheck available for Plugins with `url` option

* doc

* fix

* Bump quark-engine from 24.4.1 to 24.5.1 in /requirements (#2313)

Bumps [quark-engine](https://github.com/quark-engine/quark-engine) from 24.4.1 to 24.5.1.
- [Release notes](https://github.com/quark-engine/quark-engine/releases)
- [Commits](quark-engine/quark-engine@v24.4.1...v24.5.1)

---
updated-dependencies:
- dependency-name: quark-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump jsonschema from 4.21.1 to 4.22.0 in /requirements (#2311)

Bumps [jsonschema](https://github.com/python-jsonschema/jsonschema) from 4.21.1 to 4.22.0.
- [Release notes](https://github.com/python-jsonschema/jsonschema/releases)
- [Changelog](https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst)
- [Commits](python-jsonschema/jsonschema@v4.21.1...v4.22.0)

---
updated-dependencies:
- dependency-name: jsonschema
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump docutils from 0.20.1 to 0.21.2 in /requirements (#2312)

Bumps [docutils](https://docutils.sourceforge.io) from 0.20.1 to 0.21.2.

---
updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "Bump docutils from 0.20.1 to 0.21.2 in /requirements (#2312)"

This reverts commit 9e5106e.

* prettier

* changes (#2322)

* Phoneinfoga analyzer adjustment (#2324)

* Phoneinfoga

Signed-off-by: 0ssigeno <s.berni@certego.net>

* Linters

Signed-off-by: 0ssigeno <s.berni@certego.net>

* adjusted phoneinfoga

* Update api_app/analyzers_manager/migrations/0088_phoneinfoga_parameters.py

---------

Signed-off-by: 0ssigeno <s.berni@certego.net>
Co-authored-by: Matteo Lodi <30625432+mlodic@users.noreply.github.com>

* Fix serializer

Signed-off-by: 0ssigeno <s.berni@certego.net>

* Fix sender

Signed-off-by: 0ssigeno <s.berni@certego.net>

* pcap_analyzers adjusts + new playbook for PCAP files + upgraded Suricata to v7 (#2325)

* pcap_analyzers adjusts + new playbook for PCAP files + upgraded Suricata to v7

* adjusted hfinger

* adjust test

* adjust test and upgraded  watchman

* tests

* fix custom analysis (#2323)

* hudsonrock (#2327)

* hudsonrock

* tests

* test

* add params

* migration

* tests

* migration

* i always overlook this lol

* tlp  to amber

---------

Co-authored-by: g4ze <bhaiyajionline@gmail.com>

* Update api_app/analyzers_manager/observable_analyzers/hudsonrock.py

Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>

* black

* Fixes frontend regex (#2329)

* support phone numbers

* moved phone number validation to E.164 format

* removed dates from parsing as IP addresses

* prettier

* Cy cat#1479 (#2328)

* cycat

* cycat

* cycat wrapper done

* migration

* docs

* tests

* tests

---------

Co-authored-by: g4ze <bhaiyajionline@gmail.com>

* updated changelog

* fix loading visualizer navbar (#2335)

* fix visualizer loading

* changes

* --- (#2332)

updated-dependencies:
- dependency-name: celery[redis,sqs]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* --- (#2334)

updated-dependencies:
- dependency-name: intezer-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* --- (#2333)

updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Speed up (#2336)

Signed-off-by: 0ssigeno <s.berni@certego.net>

* Revert "--- (#2333)"

This reverts commit 12802eb.

---------

Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Daniele Rosetti <d.rosetti@certego.net>
Co-authored-by: 0ssigeno <s.berni@certego.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martina Carella <m.carella@certego.net>
Co-authored-by: Simone Berni <simone.berni2@studio.unibo.it>
Co-authored-by: Nilay Gupta <102874321+g4ze@users.noreply.github.com>
Co-authored-by: g4ze <bhaiyajionline@gmail.com>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Co-authored-by: Daniele Rosetti <55402684+drosetti@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants