after code review

interactuamovil · Mar 13, 2015 · ba1b822 · ba1b822
1 parent 9d986b5
commit ba1b822
Show file tree

Hide file tree

Showing 5 changed files with 94 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -34,6 +34,77 @@ Para hacer llamadas al API pueden utilizarse los métodos `contacts()`, `groups(
         data => (array/StdObj)[/*the data*/]
     ];
 
+    // ejemplos
+
+    //    object(stdClass) (5) {
+    //       ["code"]=>
+    //       int(500)
+    //       ["status"]=>
+    //       string(5) "Error"
+    //       ["ok"]=>
+    //       bool(false)
+    //       ["response_headers"]=>
+    //       array(4) {
+    //         [0]=>
+    //         string(34) "HTTP/1.1 500 Internal Server Error"
+    //         [1]=>
+    //         string(30) "Content-Type: application/json"
+    //         [2]=>
+    //         string(42) "Server: ContactoSMS API/3.0 (Simple 5.1.4)"
+    //         [3]=>
+    //         string(17) "Connection: close"
+    //       }
+    //       ["data"]=>
+    //       object(stdClass)#5 (2) {
+    //         ["code"]=>
+    //         int(503)
+    //         ["error"]=>
+    //         string(25) "Error interno. Reintentar"
+    //       }
+    //     }
+
+    // array(5) {
+    //   ["code"]=>
+    //   int(200)
+    //   ["status"]=>
+    //   string(2) "OK"
+    //   ["ok"]=>
+    //   bool(true)
+    //   ["response_headers"]=>
+    //   array(4) {
+    //     [0]=>
+    //     string(15) "HTTP/1.1 200 OK"
+    //     [1]=>
+    //     string(30) "Content-Type: application/json"
+    //     [2]=>
+    //     string(42) "Server: ContactoSMS API/3.0 (Simple 5.1.4)"
+    //     [3]=>
+    //     string(17) "Connection: close"
+    //   }
+    //   ["data"]=>
+    //   array(1) {
+    //     [0]=>
+    //     array(7) {
+    //       ["msisdn"]=>
+    //       string(11) "50212345678"
+    //       ["status"]=>
+    //       string(9) "SUSCRIBED"
+    //       ["phone_number"]=>
+    //       string(8) "12345678"
+    //       ["country_code"]=>
+    //       string(3) "502"
+    //       ["first_name"]=>
+    //       string(7) "Alberto"
+    //       ["full_name"]=>
+    //       string(7) "Alberto"
+    //       ["added_from"]=>
+    //       string(8) "WEB_FORM"
+    //     }
+    //   }
+    // }
+
+
+
 ```
 Ejemplos de llamadas al API:
 

diff --git a/examples/contacts.php b/examples/contacts.php
@@ -2,6 +2,10 @@
 
 include("../src/SmsApi.php");
 
+define('API_KEY', 'Your api key');
+define('API_SECRET', 'Your api secret');
+define('API_URL', 'Your api url');
+
 $api = new SmsApi(API_KEY, API_SECRET, API_URL, true); // hey you'll have your responses in arrays, did you want StdObject? change last parameter to false
 
 // Response format:
@@ -14,12 +18,6 @@
 // ];
 
 
-/// Deleting a contact....
-echo ("Deleting contact...");
-$response = $api->contacts()->deleteContact("50212345678");
-if ($response['ok']) echo "Contact deleted\n";
-else echo "Something went wrong here is the data";
-var_dump($response);
 
 /// Creating a contact......
 echo ("Creating contact...");
@@ -54,3 +52,12 @@
 if ($response['ok']) foreach ($response['data'] as $group){
     echo $group['name']."\n";
 }
+
+/// Deleting a contact....
+echo ("Deleting contact...");
+$response = $api->contacts()->deleteContact("50212345678");
+if ($response['ok']) echo "Contact deleted\n";
+else {
+    echo "Something went wrong here is the data";
+    var_dump($response);
+}
diff --git a/examples/groups.php b/examples/groups.php
@@ -1,6 +1,11 @@
 <?php
 include("../src/SmsApi.php");
 
+define('API_KEY', 'Your api key');
+define('API_SECRET', 'Your api secret');
+define('API_URL', 'Your api url');
+
+
 $api = new SmsApi(API_KEY, API_SECRET, API_URL, false /* Now I want objects... did you want array? change last parameter to true */);
 
 // Response format:

diff --git a/examples/messages.php b/examples/messages.php
@@ -2,6 +2,10 @@
 date_default_timezone_set("America/Guatemala");
 include("../src/SmsApi.php");
 
+define('API_KEY', 'Your api key');
+define('API_SECRET', 'Your api secret');
+define('API_URL', 'Your api url');
+
 $api = new SmsApi(API_KEY, API_SECRET, API_URL, false);
 
 

diff --git a/src/libs/ApiWrapper.php b/src/libs/ApiWrapper.php
@@ -94,20 +94,15 @@ public function delete($endpoint, $params=null){
     public function send($url, $params, $method, $body){
         if ($params) $url = $url."?".$params;
         $datetime = gmdate("D, d M Y H:i:s T");
-        // print($datetime."\n");
         $authentication = $this->apiKey.$datetime.$params.$body;
-        // print($authentication."|\n");
-        // print($this->apiSecret."|\n");
         $hash = hash_hmac("sha1",$authentication, $this->apiSecret,true);
-        // print($hash."\n");
         $hash = base64_encode($hash);
         $headers = array(
             "Content-type: application/json",
             "Date: $datetime",
             "Authorization: IM $this->apiKey:$hash",
             "X-IM-ORIGIN: IM_SDK_PHP",
         );
-        // print($hash."\n");
 
         $options = array(
             'http' => array(
@@ -132,6 +127,7 @@ public function send($url, $params, $method, $body){
             'response_headers' => $http_response_header,
             'data' => $json,
         );
+        var_dump($data);
         return $this->assoc?$data:(object)$data;
     }
 }