Fix #371 - now doesn't prompt for commit msg if no uncomitted files #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-hwojnick
requested review from
isc-pbarton and
isc-tleavitt
and removed request for
isc-pbarton
isc-tleavitt
changed the title
|
@isc-hwojnick this is the right general direction, but there's a bonus - if there's no commit message we have the opportunity for UserAction to alert the user on error. This is going to end up conflicting with my work in #390 so I'm going to pull these changes over there to finish and close out this PR. |
|
Folded into #390 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing only prompts users for a commit message if there are uncommitted files
Fixes #371