-
Notifications
You must be signed in to change notification settings - Fork 8
Simplify favorites and landing page for multi-namespace setup #538
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 25.15% 26.25% +1.09%
==========================================
Files 18 18
Lines 2648 2678 +30
==========================================
+ Hits 666 703 +37
+ Misses 1982 1975 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points of feedback; also, in general, please be sure to test as %Developer. If you need additional pointers to using the HCC environment for this please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure this works for %Developer by using embedded SQL for all SQL statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes, otherwise good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost...
Clearing review status - I want to play with this in HCC before giving the green light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out in HCC and it's just beautiful. Merging.
Thank you for your great work on this @isc-akadoo and also thanks to @isc-etamarch for putting up with my last minute nitpicks.
Covered by subsequent changes
Fixes #468, #510