Skip to content

Simplify favorites and landing page for multi-namespace setup #538

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 17 commits into from
Oct 22, 2024

Conversation

isc-akadoo
Copy link
Contributor

Fixes #468, #510

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.25%. Comparing base (daae595) to head (fff9b25).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 58.06% 13 Missing ⚠️
cls/SourceControl/Git/WebUIDriver.cls 0.00% 2 Missing ⚠️
cls/SourceControl/Git/Settings.cls 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   25.15%   26.25%   +1.09%     
==========================================
  Files          18       18              
  Lines        2648     2678      +30     
==========================================
+ Hits          666      703      +37     
+ Misses       1982     1975       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points of feedback; also, in general, please be sure to test as %Developer. If you need additional pointers to using the HCC environment for this please let me know.

Copy link
Collaborator

@isc-etamarch isc-etamarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure this works for %Developer by using embedded SQL for all SQL statements

@isc-akadoo isc-akadoo marked this pull request as draft October 18, 2024 19:55
@isc-etamarch isc-etamarch marked this pull request as ready for review October 21, 2024 13:43
@isc-etamarch isc-etamarch self-requested a review October 21, 2024 13:43
@isc-etamarch isc-etamarch marked this pull request as draft October 21, 2024 13:45
@isc-etamarch isc-etamarch self-assigned this Oct 21, 2024
@isc-etamarch isc-etamarch marked this pull request as ready for review October 21, 2024 14:15
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes, otherwise good to go.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost...

@isc-tleavitt isc-tleavitt self-requested a review October 21, 2024 17:30
@isc-tleavitt
Copy link
Collaborator

Clearing review status - I want to play with this in HCC before giving the green light.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out in HCC and it's just beautiful. Merging.

Thank you for your great work on this @isc-akadoo and also thanks to @isc-etamarch for putting up with my last minute nitpicks.

@isc-tleavitt isc-tleavitt dismissed isc-etamarch’s stale review October 22, 2024 00:54

Covered by subsequent changes

@isc-tleavitt isc-tleavitt merged commit f2ef459 into main Oct 22, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-468 branch October 22, 2024 00:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants