Skip to content

Fix diffview #608

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2024
Merged

Fix diffview #608

merged 3 commits into from
Oct 31, 2024

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #590

@isc-etamarch isc-etamarch linked an issue Oct 30, 2024 that may be closed by this pull request
Options at top of Git UI diff view (Ignore Whitespace, Complete file, etc.) should take effect immediately #590
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.83%. Comparing base (a7e343a) to head (947cb00).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   25.83%   25.83%           
=======================================
  Files          21       21           
  Lines        2799     2799           
=======================================
  Hits          723      723           
  Misses       2076     2076

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isc-tleavitt
isc-tleavitt requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to re-run zpm "git-source-control activate" to get changes moved to release. (And then test, because if they're not in release you haven't tried them yet!)

@isc-etamarch
Copy link
Collaborator Author

You need to re-run zpm "git-source-control activate" to get changes moved to release. (And then test, because if they're not in release you haven't tried them yet!)

Ahaha sorry I had tested on HCC without realizing the changes weren't in release

@isc-etamarch
Copy link
Collaborator Author

@isc-tleavitt should be all set now

@isc-tleavitt isc-tleavitt merged commit 3132b05 into main Oct 31, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-590 branch October 31, 2024 11:42
@isc-tleavitt isc-tleavitt mentioned this pull request Oct 31, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@isc-tleavitt isc-tleavitt isc-tleavitt approved these changes

@isc-pbarton isc-pbarton Awaiting requested review from isc-pbarton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Options at top of Git UI diff view (Ignore Whitespace, Complete file, etc.) should take effect immediately
3 participants
@isc-etamarch @codecov-commenter @isc-tleavitt