Skip to content

Commit

Permalink
Remove potential format-string attack on log_displayBox on macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelcmartin committed Jun 10, 2020
1 parent 86109d5 commit 1d5cbf3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sc2/src/libs/log/msgbox_macosx.m
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
return; // Oops, out of memory?

if (isError)
NSRunCriticalAlertPanel (titleStr, msgStr, nil, nil, nil);
NSRunCriticalAlertPanel (titleStr, @"%@", nil, nil, nil, msgStr);
else
NSRunInformationalAlertPanel (titleStr, msgStr, nil, nil, nil);
NSRunInformationalAlertPanel (titleStr, @"%@", nil, nil, nil, msgStr);

// titleStr and msgStr are autoreleased
}
Expand Down

0 comments on commit 1d5cbf3

Please # to comment.