Fix logging disable issue

intuit · Jun 20, 2018 · 2943e4d · 2943e4d
1 parent f1b1db3
commit 2943e4d
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 7 deletions.
diff --git a/src/Core/HttpClients/SyncRestHandler.php b/src/Core/HttpClients/SyncRestHandler.php
@@ -82,6 +82,14 @@ public function updateContext($newServiceContext){
         }
     }
 
+    /**
+     * Return the RequestLogger
+     * @return LogRequestsToDisk $requestLogger;
+     */
+     public function getRequestLogger(){
+       return $this->RequestLogging;
+     }
+
 
    /**
     * Return an representation of an error returned by the last request, or false if the last request was not an error.

diff --git a/src/DataService/DataService.php b/src/DataService/DataService.php
@@ -259,9 +259,9 @@ public function useJson()
      */
     public function setLogLocation($new_log_location)
     {
-        $serviceContext = $this->getServiceContext();
-        $serviceContext->setLogLocation($new_log_location);
-        $this->updateServiceContextSettingsForOthers($serviceContext);
+        $restHandler = $this->restHandler;
+        $loggerUsedByRestHandler = $restHandler->getRequestLogger();
+        $loggerUsedByRestHandler->setLogDirectory($new_log_location);
         return $this;
     }
 
@@ -287,9 +287,22 @@ public function setMinorVersion($newMinorVersion)
      */
     public function disableLog()
     {
-        $serviceContext = $this->getServiceContext();
-        $serviceContext->disableLog();
-        $this->updateServiceContextSettingsForOthers($serviceContext);
+        $restHandler = $this->restHandler;
+        $loggerUsedByRestHandler = $restHandler->getRequestLogger();
+        $loggerUsedByRestHandler->setLogStatus(false);
+        return $this;
+    }
+
+    /**
+     * Enable the logging function
+     *
+     * @return $this
+     */
+    public function enableLog()
+    {
+        $restHandler = $this->restHandler;
+        $loggerUsedByRestHandler = $restHandler->getRequestLogger();
+        $loggerUsedByRestHandler->setLogStatus(true);
         return $this;
     }
 
@@ -300,6 +313,7 @@ public function disableLog()
      */
     public function throwExceptionOnError($bool){
         $this->throwExceptionOnError = $bool;
+        return $this;
     }
 
     /**

diff --git a/src/Diagnostics/LogRequestsToDisk.php b/src/Diagnostics/LogRequestsToDisk.php
@@ -30,10 +30,26 @@ class LogRequestsToDisk
      */
     public function __construct($enableServiceRequestLogging=false, $serviceRequestLoggingLocation=null)
     {
-        $this->EnableServiceRequestsLogging = (!empty($enableServiceRequestLogging) && ("false" !== strtolower(trim($enableServiceRequestLogging))));
+        $this->EnableServiceRequestsLogging = $enableServiceRequestLogging;
         $this->ServiceRequestLoggingLocation = $serviceRequestLoggingLocation;
     }
 
+    /**
+     * Enabled or disable the log
+     * @param Boolean $status
+     */
+    public function setLogStatus($status){
+        $this->EnableServiceRequestsLogging = $status;
+    }
+
+    /**
+     * Set Log directory
+     * @param String $logDirectory
+     */
+    public function setLogDirectory($logDirectory){
+        $this->ServiceRequestLoggingLocation = $logDirectory;
+    }
+
     /**
      * Gets the log destination folder
      * @return string log destination folder