Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(upload-assets): Add more options for message in PR #2375

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

neretin-trike
Copy link

@neretin-trike neretin-trike commented Jul 7, 2023

What Changed

Change link to file, because link notation not supported in last npm version.

Add options for upload-assets plugin:

headerMessage: Custom message for header in PR
filter: Filter assets by regular expression
includeBotPrs: Whether to comment on PRs made by bots
group: Group assets by regular expression
compact: Compact view for PRs comment

Why

In case when you have a lot of assets link in pull request.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@neretin-trike neretin-trike changed the title feat(upload-assets): Add more options for message in PR WIP feat(upload-assets): Add more options for message in PR Jul 7, 2023
@neretin-trike neretin-trike changed the title WIP feat(upload-assets): Add more options for message in PR feat(upload-assets): Add more options for message in PR Jul 7, 2023
@hipstersmoothie
Copy link
Collaborator

Can you change all the package.json back? Was that needed to make this work?

@neretin-trike
Copy link
Author

Can you change all the package.json back? Was that needed to make this work?

When I used npm for install packages I have an error Unsupported URL Type "link:": link:../../packages/core, because latest version npm doesn't support this type (they replace it to file). And I thought that replacing 'link' with 'file' in all package.json files is a good solution to support contributors (like me) who use the latest version of npm

But I can remove all changes in package.json if you want to :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants