Skip to content

Commit

Permalink
docs: clarify foregroundServiceType / android compileSdk minimum
Browse files Browse the repository at this point in the history
these were tiny edits on old docs while docs.page PR was waiting on merge

from commits:
- a48abc1
- f13c5e6
  • Loading branch information
mikehardy committed Dec 17, 2024
1 parent e725161 commit 5744809
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion docs/react-native/android/foreground-service.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,15 @@ You may need access to either location, camera or microphone information in your
To specify which service types you require, add `notifee`'s foreground service to your `AndroidManifest.xml`:

```xml
<manifest>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools">
<application>
...
<!-- For example, with one service type -->
<service android:name="app.notifee.core.ForegroundService" android:foregroundServiceType="location" tools:replace="android:foregroundServiceType" />

<!-- Or, with multiple service types -->
<service android:name="app.notifee.core.ForegroundService" android:foregroundServiceType="location|camera|microphone" tools:replace="android:foregroundServiceType" />
</application>
</manifest>
```

Expand Down
4 changes: 2 additions & 2 deletions docs/react-native/installation.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ yarn add @notifee/react-native

### 2a. Android API versions

The values of the compileSdkVersion & targetSdkVersion might need to be changed. compileSdkVersion needs to be at least 33. In addition, if your app is going to request permission on Android 13 via requestPermission, targetSdkVersion needs to be at least 33, as well. These setting are in the file `/android/build.gradle`.
The values of the compileSdkVersion & targetSdkVersion might need to be changed. compileSdkVersion needs to be at least 34. In addition, if your app is going to request permission on Android 13 via requestPermission, targetSdkVersion needs to be at least 33, as well. These setting are in the file `/android/build.gradle`.

```gradle
buildscript {
ext {
compileSdkVersion = 33 // at least 33
compileSdkVersion = 34 // at least 34
targetSdkVersion = 33 // If requesting permission on Android 13 via requestPermission, at least 33
...
}
Expand Down

0 comments on commit 5744809

Please # to comment.