fix(android): prevent RemoteServiceException$ForegroundServiceDidNotStartInTimeException #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handled the following raise condition:
when stopSelf() is called before startForeground then it will lead to a crash ->
`Fatal Exception: android.app.RemoteServiceException$ForegroundServiceDidNotStartInTimeException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{ab29442 u0 live.friend.dostt/app.notifee.core.ForegroundService c:live.friend.dostt}`
To easily reproduce this crash just call the `stopSelf()` method before calling `startForeground()` method
solution:
we have to make sure to call `startForeground` before calling `stopSelf()`, for this, i've
added a dummy notification to ensure `startForeground` is always called before calling `stopSelf()`, with `notification id 1`.
This will prevent the crash `ForegroundServiceDidNotStartInTimeException`
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/notifee~1202 Documentation is deployed and generated using docs.page. |
|
|
ajitpatel28
changed the title
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr i've tried to handle the following raise condition:
when stopSelf() is called before startForeground then it will lead to a crash ->
Fatal Exception: android.app.RemoteServiceException$ForegroundServiceDidNotStartInTimeException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{ab29442 u0 live.friend.dostt/app.notifee.core.ForegroundService c:live.friend.dostt}To easily reproduce this crash just call the
stopSelf()method before callingstartForeground()methodsolution:
we have to make sure to call
startForegroundbefore callingstopSelf(), for this, i'veadded a dummy notification to ensure
startForegroundis always called before callingstopSelf(), withnotification id 1.This will prevent the crash
ForegroundServiceDidNotStartInTimeException