Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[STORAGE][TYPES][BUGFIX] TaskEvent was incorrectly typed TaskState #2303

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

tkow
Copy link

@tkow tkow commented Jun 28, 2019

close #2302

Summary

The type of storage task event is wrong.

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in /tests/e2e/*
  • Updated the documentation in the docs repo
    • LINK TO DOCS PR HERE
  • Flow types updated
  • Typescript types updated

Test Plan

Release Plan

[CATEGORY][type] [LOCATION] - Message


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that looks pretty obvious - most type changes are backwards incompatible, but it seems like this could only have been used with a cast so I’d be shocked if this hurt people? I mean, I would probably still mark it v5.6 (using the updated “breaking change in minor” semver for v5.x.x) but this seems like it can only help. What do you think?

@mikehardy
Copy link
Collaborator

I just checked v6 and this looks fixed there, I don’t see a problem between the branches

@mikehardy mikehardy added plugin: storage Firebase Cloud Storage tools: typings TypeScript / Flow Version: 5.x.x labels Jun 28, 2019
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v5.x.x@af32cc4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v5.x.x    #2303   +/-   ##
=========================================
  Coverage          ?   76.27%           
=========================================
  Files             ?       61           
  Lines             ?     1576           
  Branches          ?        0           
=========================================
  Hits              ?     1202           
  Misses            ?      374           
  Partials          ?        0

@mikehardy
Copy link
Collaborator

just read your thoughts on the linked issue, sounds good

let me think about how to release this, but I have no problem in general with a compatibility break if that’s what a fix like this so it’ll be either 5.5.5 or 5.6.0. Either way, thanks for the fix and I’ll merge it now, then you can depend on the commit hash or use patch-package with confidence it will converge with the next release

@mikehardy mikehardy changed the title fix type TaskEvent [STORAGE][TYPES][BUGFIX] TaskEvent was incorrectly typed TaskState Jun 28, 2019
@mikehardy mikehardy merged commit a451cf3 into invertase:v5.x.x Jun 28, 2019
@tkow
Copy link
Author

tkow commented Jun 28, 2019

@mikehardy Sure. Thank you for that. This project's very amazingly nice for me and a lot of help us. I
have understood this project have tough work for migration to v6. I appreciate it.

@tkow tkow deleted the v5.x.x-fix-type-storage-event-task branch June 28, 2019 04:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugin: storage Firebase Cloud Storage tools: typings TypeScript / Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants