fix(ui): truncate error description so toast is always close-able #6946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
brandonrising
approved these changes
Sep 25, 2024
psychedelicious
force-pushed
the
maryhipp/error-toast-trunace
branch
from
8c08aa6
to
06d864f
Compare
psychedelicious
approved these changes
Sep 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If an invocation error happens that results in a very long
description, the toast can take over the vertical space on screen and be impossible to close without refreshing the page. This limits the toast description for these errors to 4 lines.Related Issues / Discussions
QA Instructions
Merge Plan
Checklist