fix(ui): new image selection logic #6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Sep 25, 2024
…w changed We will be setting the selection in just a moment anyways.
Fixes an issue where auto-switch would not select the correct view or offset when new image arrives
hipsterusername
force-pushed
the
psyche/fix/new-image-selection
branch
from
e901b50
to
078cc18
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New images weren't being selected. Actually, they were, but then they were quickly unselected.
The changes in #6930 unmasked a deeper logic issue that then became a bug.
Related Issues / Discussions
n/a
QA Instructions
Test with auto-switch enabled.
Test matrix:
Merge Plan
n/a
Checklist