Update Compel to 2.1.1 and apply Sentences Split logic #8026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
hipsterusername
requested review from
lstein,
blessedcoolant,
psychedelicious and
jazzhaiku
as code owners
psychedelicious
approved these changes
May 26, 2025
psychedelicious
approved these changes
May 26, 2025
| @@ -205,6 +206,7 @@ def _lora_loader() -> Iterator[Tuple[ModelPatchRaw, float]]: | |||
| returned_embeddings_type=ReturnedEmbeddingsType.PENULTIMATE_HIDDEN_STATES_NON_NORMALIZED, # TODO: clip skip | |||
| requires_pooled=get_pooled, | |||
| device=TorchDevice.choose_torch_device(), | |||
| split_long_text_mode=SplitLongTextMode.SENTENCES, | |||
There was a problem hiding this comment.
This is the default behaviour in v2.1.1, but it doesn't hurt to manually specify it.
https://github.com/damian0815/compel/blob/2.1.1/src/compel/compel.py#L34
psychedelicious
force-pushed
the
compel-updates
branch
from
475ad71 to
3000662
Compare
hipsterusername
force-pushed
the
compel-updates
branch
from
3000662 to
ed8659f
Compare
jazzhaiku
approved these changes
May 27, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces changes to improve text handling in the compel node and updates project metadata and dependencies in
pyproject.toml. Key updates include enabling sentence-based splitting for long text prompts, updating dependency versions, and revising project metadata to reflect the current state of the project.We should consider advising that very long prompts may have different results using the new parsing logic, but are reproducible if manually split using the .and() parsing logic.
Changes to text handling in
compel.py:SplitLongTextMode.SENTENCESto thesplit_long_text_modeparameter in two instances ofCompelinitialization, enabling more graceful splitting of long text prompts. [1] [2]SplitLongTextModefrom thecompellibrary to support the new functionality.Updates to
pyproject.toml:compeldependency version from2.0.2to2.1.1to ensure compatibility with the new text-splitting functionality.QA Instructions
Test prompts (I've done testing myself and seen behavior continue to function)
Merge Plan
N/A
Checklist
What's Newcopy (if doing a release after this PR)