Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(ios): add path utilities to bridge #3842

Merged
merged 15 commits into from
Nov 28, 2020
Merged

feat(ios): add path utilities to bridge #3842

merged 15 commits into from
Nov 28, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Nov 21, 2020 •
edited
Loading

Usable by plugins that deal with file paths, such as Camera and Notifications.

@imhoffd imhoffd added this to the 3.0.0 milestone Nov 21, 2020
@imhoffd imhoffd requested a review from ikeith November 23, 2020 17:36
ikeith
ikeith suggested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@ikeith ikeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's an internal implementation detail, I don't think it's critical. But the resolvers would be much cleaner if they were made into an enum instead of a collection of classes.

@imhoffd imhoffd changed the title feat(ios): expose CAPFile utilities feat(ios): add path utilities to bridge Nov 23, 2020
@imhoffd imhoffd requested a review from ikeith November 23, 2020 23:22
ikeith
ikeith suggested changes Nov 24, 2020
View reviewed changes
@imhoffd imhoffd requested a review from ikeith November 24, 2020 18:21
@imhoffd imhoffd requested a review from ikeith November 24, 2020 20:41
@imhoffd imhoffd requested a review from ikeith November 25, 2020 20:33
@imhoffd imhoffd merged commit c31eb35 into main Nov 28, 2020
@imhoffd imhoffd deleted the file-access branch November 28, 2020 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ikeith ikeith ikeith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@imhoffd @ikeith