Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(android): Fix for #6258, Add support for modern Huawei devices #6402

Merged
merged 10 commits into from
Mar 27, 2023
Merged

feat(android): Fix for #6258, Add support for modern Huawei devices #6402

merged 10 commits into from
Mar 27, 2023

Conversation

zakuru
Copy link
Contributor

@zakuru zakuru commented Mar 16, 2023

Closes issue issue #6258
MR created from #6306

@zakuru zakuru changed the title Add support for modern Huawei devices feat(android): Fix for #6258, Add support for modern Huawei devices Mar 16, 2023
markemer
markemer requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just need to restore our legacy code fixes with InternalUtils

@markemer
Copy link
Member

Also, does this replace #6306?

@markemer markemer mentioned this pull request Mar 20, 2023
Closed
@zakuru
Copy link
Contributor Author

zakuru commented Mar 20, 2023

Hi @markemer

Since I saw no activity for a while in the other PR I created that one. But in don't want to over step on the initial one please advise the best to do.

Also regarding the changes you requested I will check them again and get back you to you soon. I suspect that they we're caused by the linting process npm run fmt

Will get back to you in few days

@markemer
Copy link
Member

Hi @markemer

Since I saw no activity for a while in the other PR I created that one. But in don't want to over step on the initial one please advise the best to do.

Also regarding the changes you requested I will check them again and get back you to you soon. I suspect that they we're caused by the linting process npm run fmt

Will get back to you in few days

Yeah, I hadn't heard anything on the last one either, so this works for me - just let me know when you're ready and I'll review.

@zakuru
Copy link
Contributor Author

zakuru commented Mar 22, 2023

@markemer applied the fixes following your feed backs
Thanks

@zakuru zakuru requested review from markemer and removed request for theproducer, ItsChaceD, IT-MikeS and giralte-ionic March 22, 2023 19:41
@markemer markemer requested review from ItsChaceD and removed request for markemer March 22, 2023 19:41
@markemer markemer merged commit 17f2f4a into ionic-team:main Mar 27, 2023
markemer added a commit that referenced this pull request Apr 17, 2023
@zakuru @markemer
feat(android): Fix for #6258, Add support for modern Huawei devices (#…
ae709d4 
…6402)

Co-authored-by: Mark Anderson <mark@ionic.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@markemer markemer markemer approved these changes

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@theproducer theproducer Awaiting requested review from theproducer

@IT-MikeS IT-MikeS Awaiting requested review from IT-MikeS

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakuru @markemer @giralte-ionic