Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cli): Migrate more plugin variables #6552

Merged
merged 2 commits into from
May 2, 2023
Merged

fix(cli): Migrate more plugin variables #6552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45ba2ca
fix(cli): Migrate more plugin variables
jcesarmobile May 2, 2023
eddd71f
fmt
jcesarmobile May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions cli/src/tasks/migrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,11 @@ export async function migrateCommand(
androidxMaterialVersion: '1.8.0',
androidxExifInterfaceVersion: '1.3.6',
androidxCoreKTXVersion: '1.10.0',
googleMapsPlayServicesVersion: '18.1.0',
googleMapsUtilsVersion: '3.4.0',
googleMapsKtxVersion: '3.4.0',
googleMapsUtilsKtxVersion: '3.4.0',
kotlinxCoroutinesVersion: '1.6.4',
};
for (const variable of Object.keys(pluginVariables)) {
await updateFile(
Expand Down Expand Up @@ -398,16 +403,22 @@ async function installLatestLibs(
}

async function writeBreakingChanges() {
const breaking = ['@capacitor/device'];
const breaking = [
'@capacitor/camera',
'@capacitor/device',
'@capacitor/local-notifications',
'@capacitor/push-notifications',
];
const broken = [];
for (const lib of breaking) {
if (allDependencies[lib]) {
broken.push(lib);
}
}
// TODO - remove "next" from the url once capacitor 5 is final
if (broken.length > 0) {
logger.info(
`IMPORTANT: Review https://capacitorjs.com/docs/updating/5-0#plugins for breaking changes in these plugins that you use: ${broken.join(
`IMPORTANT: Review https://capacitorjs.com/docs/next/updating/5-0#plugins for breaking changes in these plugins that you use: ${broken.join(
', ',
)}.`,
);
Expand Down