Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cli): Attempt to verify non-cjs modules exist if cjs resolution fails #7310

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix(cli): Attempt to verify non-cjs modules exist if cjs resolution fails #7310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f6ca6
fix(cli): Attempt to verify non-cjs modules exist if cjs resolution
Steven0351 Mar 4, 2024
ba3c302
chore: Use ESM import
Steven0351 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cli/src/util/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { readFileSync } from '@ionic/utils-fs';
import { existsSync } from 'fs';
import { resolve } from 'path';
import type typescript from 'typescript';

Expand Down Expand Up @@ -56,6 +57,10 @@ export function resolveNode(
try {
return require.resolve(pathSegments.join('/'), { paths: [root] });
} catch (e) {
const path = [root, 'node_modules', ...pathSegments].join('/');
if (existsSync(path)) {
return path;
}
return null;
}
}