Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update stencil core #30132

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 13, 2025

We have shipped various of improvements to the Stencil project and runtime. You can take a close look at our changelog but since v4.20.0 we mainly shipped improvements on the following issues:

Major Improvements:

  • Enhanced Shadow DOM and hydration support
    • Improved client-side hydration for SSR
    • Better handling of shadow root styles and component hydration
    • More reliable serialization of Shadow DOM components

Key Bug Fixes:

  • Resolved performance issues due to detached nodes in memory
  • Fixed several critical issues with scoped slots and component styling
  • Improved handling of SVG class attributes and template tags
  • Enhanced runtime decorator functionality
  • Better handling of form-associated callbacks

Technical Updates:

  • Updated to TypeScript 5.5
  • Added support for customizable Mermaid diagram colors in documentation

I don't see any critical changes that may impact Ionic users and feel confident we can ship this.

Dev Build

8.5.4-dev.11743814940.14e938eb

@christian-bromann christian-bromann requested a review from a team as a code owner January 13, 2025 19:48
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 0:07am

@github-actions github-actions bot added the package: core @ionic/core package label Jan 13, 2025
@Sagie501
Copy link

Does this will solve the following issue?
#30084

@christian-bromann
Copy link
Member Author

Does this will solve the following issue?

Definitely worth verifying this! I created a dev build 8.4.2-dev.11736797843.16cc5058 which we currently use to test.

@Sagie501
Copy link

Does this will solve the following issue?

Definitely worth verifying this! I created a dev build 8.4.2-dev.11736797843.16cc5058 which we currently use to test.

I tried it now it the issue still exist 😔

@capc0
Copy link
Contributor

capc0 commented Jan 17, 2025

related issue #30136

@brandyscarney brandyscarney changed the title chore(core): update stencil core chore(deps): update stencil core Jan 17, 2025
@capc0
Copy link
Contributor

capc0 commented Jan 23, 2025

I have tested the dev build (8.4.2-dev.11736797843.16cc5058) with updated stencil a bit and found a 2 issues in the console when clicking through our app:


image image
image image

@a7medm7med
Copy link

a7medm7med commented Feb 15, 2025

@christian-bromann I'm encountering the same errors with Stencil 4.26.0, and they only occur when using React.

Screenshot 2025-02-15 173628

@a7medm7med
Copy link

@christian-bromann The same type of error also occurs in Vue (I haven't tested it in Angular yet).

Screenshot 2025-02-17 190515

@ralphcode
Copy link

ralphcode commented Mar 13, 2025

Fyi, I've tested this locally and upgrading to 4.27.2 it does not appear to fix #30215 (in Angular)

@christian-bromann do you by any chance know if this is a bug in Ionic or should be replicated in Stencil to be fixed there? Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants