Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added support for AppleTV OS #228

Merged
merged 1 commit into from
Sep 16, 2016
Merged

added support for AppleTV OS #228

merged 1 commit into from
Sep 16, 2016

Conversation

Vrixyz
Copy link

@Vrixyz Vrixyz commented May 13, 2016

Hello,

We use your work internally in my company, and we needed to deploy automatically on tvOS, so I tweaked the code to allow that. (thanks by the way for continuing ios-deploy 🎉 )

Please consider my changes.

Some explaination about the patch :

  • find_path() was not working for some paths (I believe it was "iOS DeviceSupport", probably because of the space), so I tweaked it a little bit because my tvOS support path was in this folder.
    My fix to this issue has not been to fix find_path() per se, but to make it lower level, and escape the paths before calling find_path.
  • I added a deviceClassPath variable (2 to be exact, but you can read 👍 ), to adapt with tvOS location, this change is easy to read I believe.

I submit this change from home, so I can't test it with an AppleTV, and your codebase changed slightly, so maybe the patch isn't ready, but it shouldn't be far from it, as it worked on my workplace.

I would appreciate feedbacks, thanks 😄

@shazron shazron added this to the 2.0.0 milestone May 25, 2016
@jakepetroules
Copy link

Awesome, qbs will enjoy this as well.

@shazron shazron modified the milestones: 1.8.8, 2.0.0 Sep 15, 2016
@shazron
Copy link

shazron commented Sep 16, 2016

Reviewed and tested by deploying to an iOS device. Can't test on tvOS, so I'll leave that for users to test. LGTM. merging

@shazron shazron merged commit 71e14be into ios-control:master Sep 16, 2016
@shazron
Copy link

shazron commented Sep 16, 2016

1.9.0 published: https://github.com/phonegap/ios-deploy/releases/tag/1.9.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants