Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

infra: fix macOS *san builds #642

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Dec 26, 2018

Building with --config *san on macOS doesn't work properly due to _FORTIFY_SOURCE already being defined, producing a lot of the following warning:

In file included from <built-in>:362:
<command line>:1:9: warning: '_FORTIFY_SOURCE' macro redefined [-Wmacro-redefined]
#define _FORTIFY_SOURCE 1
        ^
<built-in>:349:9: note: previous definition is here
#define _FORTIFY_SOURCE 0
        ^
1 warning generated.

References:
bazelbuild/bazel#6932
google/sanitizers#247

The only reasonable thing is to make sure _FORTIFY_SOURCE is set to 0 when asan/msan/tsan is used.

Test Plan:

CI

@thibault-martinez thibault-martinez added the A-infra Area - Infrastructure label Dec 26, 2018
@th0br0 th0br0 merged commit 7f243c4 into iotaledger:develop Dec 27, 2018
@thibault-martinez thibault-martinez deleted the infra-osx-asan branch December 27, 2018 14:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
A-infra Area - Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants