This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
ISSUE-78: Remove fix hashing function from signing class #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
suggested changes
Sep 10, 2019
There was a problem hiding this comment.
The main problem i have with this is that it changes classes that we use in IRI as well.
https://github.com/iotaledger/iri/blob/dev/src/main/java/com/iota/iri/crypto/SpongeFactory.java
https://github.com/iotaledger/iri/blob/dev/src/main/java/com/iota/iri/utils/Pair.java
Not that thats such a big problem, but it wasnt really a problem we needed solving, and this might add confusion later (definitely for me, is it .hi, or .getRight())
ezienecker
force-pushed
the
feature/ISSUE-78
branch
from
23fa845 to
bfadc9f
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.