Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Integration tests skeleton #26

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Integration tests skeleton #26

merged 9 commits into from
Jan 9, 2019

Conversation

fntlnz
Copy link
Member

@fntlnz fntlnz commented Jan 6, 2019

Related to #25

What I did

  • Put together an integration testing framework using go-check and kind (the idea is that a test starts kubernetes and then uses the kubectl-trace binary against it)
  • Tested a basic kubectl trace run with no attach

fntlnz added 4 commits January 6, 2019 02:17
@fntlnz
feat(kubectl-trace): prepare vendor for integration tests
6c22401 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(integration): run without attach
bf0e4e9 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(integration): integration in travis
1349496 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(kubectl-trace): vendor update
5aad5f7 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the feature/integration-tests branch from 623c3a8 to 5aad5f7 Compare January 6, 2019 01:44
@fntlnz fntlnz requested a review from leodido January 6, 2019 09:05
leodido
leodido approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me.

fntlnz added 2 commits January 8, 2019 01:53
@fntlnz
feat(integration): separate base build and kubectl trace image
8c62a48 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(kubectl-trace): only push images on success
9cbfd9c 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the feature/integration-tests branch from 32425f2 to 9cbfd9c Compare January 8, 2019 01:39
fntlnz added 3 commits January 9, 2019 01:12
@fntlnz
feat(integration): copy bpftrace image inside the kind docker daemon
b2cdc3b 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(integration): build integration test with ldflags
77700ca 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
feat(integration): build images before integration tests
229f303 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz changed the title WIP: Initial Integration tests Integration tests skeleton Jan 9, 2019
@fntlnz fntlnz merged commit 933a110 into master Jan 9, 2019
@fntlnz fntlnz deleted the feature/integration-tests branch January 9, 2019 08:58
This was referenced Jan 9, 2019
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leodido leodido leodido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fntlnz @leodido