fix: Specify resource requests and limits for trace job #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalehamel
force-pushed
the
resource-requests-limits
branch
from
1c11a16 to
b5bb5df
Compare
dalehamel
changed the title
fntlnz
approved these changes
Jan 28, 2019
|
@dalehamel I was wondering if this could have any impact in programs using maps like for sum and hist but you set the hard limits to 1 CPU and 1G of Memory so it seams reasonable. |
Yeah i think if this becomes an issue, someone will open a bug report and they'd be able to indicate what caused the resource usage to go above that. 1GB and 1 full CPU should be a lot |
leodido
approved these changes
Jan 28, 2019
|
Thanks @dalehamel |
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This sets the trace job to be burstable, with a very low CPU requirement (1/10th of a CPU), to ensure that the job can be easily scheduled without being disruptive. It sets a maximum of 1 full CPU as well.
Similarly, for memory it requires 100mb, with a maximum of 1Gb.
We can tune these up or down as need be, but for now this should be a wide range to operate in.
If #47 is merged, then requests/limits should be applied to the initContainer as well.
@fntlnz what do you think?