Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Don't build bpftrace tests #72

Merged
merged 1 commit into from
May 7, 2019

Conversation

acj
Copy link
Contributor

@acj acj commented Apr 28, 2019

My original branch depended on an upstream change in bpftrace, but it's not needed. Providing bpftrace as a build target is enough.

Resolves #43.

@acj acj changed the title Don't build bpftrace tests fix: Don't build bpftrace tests Apr 29, 2019
@acj acj force-pushed the disable-bpftrace-tests branch from 7c5b564 to 40c841d Compare April 29, 2019 00:32
@fntlnz fntlnz requested review from fntlnz and leodido April 30, 2019 00:39
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Thanks!

Copy link
Member

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @acj thanks for this one!
LGTM!

@fntlnz fntlnz merged commit 0711573 into iovisor:master May 7, 2019
@acj acj deleted the disable-bpftrace-tests branch May 7, 2019 09:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable bpftrace tests build
3 participants