Skip to content

Removes unused fields #94

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

patilsuraj767
Copy link
Contributor

fixes: #82

@RobotSail
Copy link
Collaborator

@cooktheryan @coryschwartz Are we okay with removing these? I know that we're planning to add an Ingress controller at some point but I was thinking that we can just add them back if needed.

@cooktheryan
Copy link
Collaborator

@RobotSail +1

@RobotSail
Copy link
Collaborator

Alright it looks like this PR is suffering from the Ginkgo version mismatch issue, we had solved that in PR #87 but it never landed in main. I'll make a fix and then we can rebase this PR & then it should be good to merge.

@RobotSail
Copy link
Collaborator

@patilsuraj767 I don't have permissions to push to your branch but you'll need to make these changes for the build to pass:

In Makefile on line 5:

GINKGO_VERSION := v2.7.0

Replace line 326 in Makefile with this:

GINKGO_URL := github.com/onsi/ginkgo/v2/ginkgo@$(GINKGO_VERSION)

Then in go.mod, set ginkgo to version v2.7.0 on line 12:

	github.com/onsi/ginkgo/v2 v2.7.0

@patilsuraj767
Copy link
Contributor Author

Thanks @RobotSail I have made the changes and pushed the commit to PR.

@RobotSail
Copy link
Collaborator

Thanks @patilsuraj767, cluster-follow is still broken but that's been an issue and I don't think this PR has anything to do with it.

@RobotSail RobotSail merged commit 080e796 into ipfs-cluster:main Jan 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused fields
3 participants