Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove trace goroutine for dagstore wrapper #419

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close #418

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #419 (1b8b0b6) into master (364479f) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   20.58%   20.53%   -0.05%     
==========================================
  Files         193      193              
  Lines       23642    23621      -21     
==========================================
- Hits         4866     4851      -15     
+ Misses      17987    17981       -6     
  Partials      789      789              
Flag Coverage Δ
unittests 20.53% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dagstore/wrapper.go 39.76% <ø> (-2.14%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 40bd408 into master Aug 29, 2023
@LinZexiao LinZexiao deleted the fix/remove-trace-goroutine branch August 29, 2023 02:26
@simlecode simlecode restored the fix/remove-trace-goroutine branch August 29, 2023 02:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[droplet] remove trace goroutine for dagstore wrapper
3 participants