Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support storage deal protocol v2 #435

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 19, 2023

关联的Issues (Related Issues)

close #421

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #435 (ebfa3e3) into master (f49ad93) will decrease coverage by 0.79%.
The diff coverage is 8.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   20.50%   19.71%   -0.79%     
==========================================
  Files         193      196       +3     
  Lines       23640    25438    +1798     
==========================================
+ Hits         4847     5016     +169     
- Misses      18002    19542    +1540     
- Partials      791      880      +89     
Flag Coverage Δ
unittests 19.71% <8.88%> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
api/clients/modules.go 0.00%
api/clients/signer/sign_client.go 0.00%
cli/util.go 0.00%
cmd/droplet-client/storage.go 0.00%
models/repo/repo.go ø
storageprovider/deal_handler.go 0.00%
storageprovider/storage_provider.go 0.00%
storageprovider/stream.go 0.00%
types/type_cbor_gen.go 0.00%
models/badger/migrate/v2.3.0/type_cbor_gen.go 27.20%
... and 4 more

@simlecode simlecode force-pushed the feat/deal-protocol-v2 branch from ebfa3e3 to 6edfeda Compare September 19, 2023 08:09
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 46865fe into master Sep 19, 2023
@LinZexiao LinZexiao deleted the feat/deal-protocol-v2 branch September 19, 2023 09:11
simlecode pushed a commit that referenced this pull request Oct 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[droplet] 不兼容boost最新版本协议发单
3 participants