Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add timeout for query ask #449

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix: add timeout for query ask #449

merged 1 commit into from
Oct 8, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close #433

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #449 (2876111) into master (ce9c52a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   19.47%   19.50%   +0.02%     
==========================================
  Files         198      198              
  Lines       25754    25764      +10     
==========================================
+ Hits         5016     5025       +9     
- Misses      19855    19858       +3     
+ Partials      883      881       -2     
Flag Coverage Δ
unittests 19.50% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/droplet-client/retrieval.go 0.00% <0.00%> (ø)
cmd/droplet-client/storage.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit d1173f2 into master Oct 8, 2023
@LinZexiao LinZexiao deleted the fix/query-ask-hang branch October 8, 2023 02:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

droplet-client query 网络不通会一直卡住
3 participants