Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat/use deal bound from policy directly #467

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #467 (854b3c5) into master (14d59f6) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   19.72%   19.72%   -0.01%     
==========================================
  Files         200      200              
  Lines       25855    25857       +2     
==========================================
  Hits         5100     5100              
- Misses      19873    19875       +2     
  Partials      882      882              
Flag Coverage Δ
unittests 19.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
version/version.go 0.00% <ø> (ø)
client/client.go 8.76% <0.00%> (ø)
storageprovider/deal_handler.go 0.00% <0.00%> (ø)
storageprovider/provider.go 0.00% <0.00%> (ø)

@simlecode simlecode merged commit 4398d27 into master Oct 18, 2023
@simlecode simlecode deleted the fix/use-deal-bound-from-policy-directly branch October 18, 2023 07:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants