Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Paid retrieval failed #484

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Paid retrieval failed #484

merged 1 commit into from
Nov 7, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Nov 6, 2023

关联的Issues (Related Issues)

fix: #477

在 447 中的修复会导致检索卡住(设置了检索价格)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Nov 6, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.10@0633f61). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/v2.10     #484   +/-   ##
================================================
  Coverage                 ?   19.94%           
================================================
  Files                    ?      200           
  Lines                    ?    25900           
  Branches                 ?        0           
================================================
  Hits                     ?     5166           
  Misses                   ?    19846           
  Partials                 ?      888           
Flag Coverage Δ
unittests 19.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit a30f47c into release/v2.10 Nov 7, 2023
@LinZexiao LinZexiao deleted the fix/paid-retrieval branch November 7, 2023 02:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants