Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat/start dagstore in goroutine #506

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close #504

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cb37c59) 25.51% compared to head (6f74741) 25.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   25.51%   25.49%   -0.03%     
==========================================
  Files         178      178              
  Lines       21063    21068       +5     
==========================================
- Hits         5374     5371       -3     
- Misses      14781    14787       +6     
- Partials      908      910       +2     
Flag Coverage Δ
unittests 25.49% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dagstore/wrapper.go 39.16% <50.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit c06a473 into master Dec 20, 2023
1 check passed
@simlecode simlecode deleted the feat/start-dagstore-in-goroutine branch December 20, 2023 07:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a mass of shard to initialize when launch up will affect othter function of droplet
3 participants