Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement direct deal #509

Merged
merged 17 commits into from
Mar 11, 2024
Merged

feat: implement direct deal #509

merged 17 commits into from
Mar 11, 2024

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Feb 7, 2024

关联的Issues (Related Issues)

close #425

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 15.27514% with 893 lines in your changes are missing coverage. Please review.

Project coverage is 25.00%. Comparing base (2eae8a5) to head (ee9ed0d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   25.49%   25.00%   -0.50%     
==========================================
  Files         178      182       +4     
  Lines       21068    22111    +1043     
==========================================
+ Hits         5371     5528     +157     
- Misses      14787    15654     +867     
- Partials      910      929      +19     
Flag Coverage Δ
unittests 25.00% <15.27%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/storage-deals.go 3.19% <ø> (ø)
metrics/metrics.go 50.00% <ø> (ø)
models/module.go 0.00% <ø> (ø)
models/mysql/storage_deal.go 66.96% <100.00%> (+0.29%) ⬆️
models/repo/repo.go 100.00% <ø> (ø)
storageprovider/modules.go 0.00% <0.00%> (ø)
rpc/rpc.go 0.00% <0.00%> (ø)
models/mysql/db.go 63.01% <40.00%> (-0.37%) ⬇️
models/badger/db.go 56.34% <0.00%> (-2.82%) ⬇️
models/badger/utils.go 47.67% <50.00%> (+0.61%) ⬆️
... and 8 more

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 1e81ea3 into master Mar 11, 2024
1 check passed
@LinZexiao LinZexiao deleted the feat/direct-deal branch March 11, 2024 07:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持 Direct data onboarding
3 participants