Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: 增加Version接口/implement Version api #73

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

resolve filecoin-project/venus#5132

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #73 (3a51dc9) into master (95ce885) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   66.15%   66.13%   -0.02%     
==========================================
  Files          26       26              
  Lines        1743     1745       +2     
==========================================
+ Hits         1153     1154       +1     
- Misses        521      522       +1     
  Partials       69       69              
Flag Coverage Δ
unittests 66.13% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/rpc_impl.go 93.54% <0.00%> (-6.46%) ⬇️
marketevent/market_client.go 67.59% <0.00%> (-2.78%) ⬇️
walletevent/wallet_client.go 67.16% <0.00%> (-2.24%) ⬇️
proofevent/proof_event.go 89.56% <0.00%> (+6.08%) ⬆️

@simlecode simlecode changed the title feat: implement Version api feat: 增加Version接口/implement Version api Aug 3, 2022
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 51f0bc0 into master Aug 3, 2022
@diwufeiwen diwufeiwen deleted the feat/impl_Version_api branch August 3, 2022 07:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Venus] 各组件增加 Version 接口
3 participants