Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

opt: add time flag for msg list command #375

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close filecoin-project/venus#6172

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Merging #375 (07998b7) into master (a6bebfc) will decrease coverage by 0.10%.
The diff coverage is 28.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   58.07%   57.97%   -0.10%     
==========================================
  Files          68       68              
  Lines        7616     7629      +13     
==========================================
  Hits         4423     4423              
- Misses       2836     2847      +11     
- Partials      357      359       +2     
Flag Coverage Δ
unittests 57.97% <28.57%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/messager_impl.go 74.24% <100.00%> (ø)
service/message_service.go 59.92% <100.00%> (ø)
models/mysql/message.go 74.45% <20.00%> (-0.73%) ⬇️
models/sqlite/message.go 81.53% <20.00%> (-0.79%) ⬇️
cli/msg.go 0.00% <0.00%> (ø)

@simlecode simlecode force-pushed the opt/cmd/msg-list-with-time branch from 76238c3 to 07998b7 Compare December 14, 2023 06:20
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 9c61238 into master Dec 14, 2023
@LinZexiao LinZexiao deleted the opt/cmd/msg-list-with-time branch December 14, 2023 06:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sophon-messager] msg list不支持使用--time参数来过滤
3 participants