This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: add test for config set with number #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
1 task
alanshaw
pushed a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
May 15, 2019
Anything that isn't a string needs to be passed with `--json`. fixes #881 Depends on: * [x] ipfs-inactive/interface-js-ipfs-core#470 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything that isn't a string needs to be passed with
--jsonto the config set HTTP API. This PR tests that this is happening by virtue of setting a non string value.