This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Feat/bitswap pr improvements #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Edited the dup_blocks_test to run as a benchmark -- cause that's what it is. It was failing even in @whyrusleeping PR for me on my machine, which isn't that surprising. |
|
@hannahhoward yeah, i had the sensetivity on those tests set to zero, so any duplicate blocks caused a failure |
So that CI passes, and because it's not reliable as a test, and is more a benchmark to measure performance, convert dup_block_test.go to a benchmark, which can be run using `go test -bench .`
hannahhoward
force-pushed
the
feat/bitswap-pr-improvements
branch
from
54270f9 to
d6144d9
Compare
|
@whyrusleeping That makes sense. Also though w/o code to actually mitigate the issue, it makes sense to think of this as a benchmark. Once such code exists, maybe we make it a test to prevent regressions. |
Stebalien
approved these changes
Oct 29, 2018
|
(it passed the merge test...) |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…vements Feat/bitswap pr improvements This commit was moved from ipfs/go-bitswap@6338b06
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Bring over useful additional testing from #8 as well as fix issue with Bitswap sessions not matching sessions interface.
Implementation
Copy two relevant commits from that PR, and also copy the full dup_blocks_test.go file
For discussion
Should the interface fix and tests be separated?
Fixes ipfs/kubo#5640