Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add MustParse #139

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Add MustParse #139

merged 1 commit into from
Jun 27, 2022

Conversation

mg98
Copy link
Contributor

@mg98 mg98 commented Jun 24, 2022

I found this function to be extremely useful, especially for testing.

@welcome
Copy link

welcome bot commented Jun 24, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@mg98 mg98 force-pushed the feat/must-parse branch from b04449f to 386c6cc Compare June 24, 2022 15:35
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen/used this function several times as well.

@Stebalien Stebalien merged commit 8f7d7ac into ipfs:master Jun 27, 2022
@mg98 mg98 deleted the feat/must-parse branch June 27, 2022 19:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants