Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Extract non-core functionality from go-cid into go-cidutil #69

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Extract non-core functionality from go-cid into go-cidutil #69

merged 1 commit into from
Aug 21, 2018

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Aug 17, 2018

Closes #68

@ghost ghost assigned kevina Aug 17, 2018
@ghost ghost added the status/in-progress In progress label Aug 17, 2018
@kevina
Copy link
Contributor Author

kevina commented Aug 17, 2018 •
edited
Loading

@Stebalien

Before we merge and propitiate this let get ipfs/go-cidutil#4 in.

The gx publish is pinned on one of my personal ipfs nodes and was required to properly test the extraction to go-cidutil.

Stebalien
Stebalien approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when ready.

@kevina kevina merged commit fb85ebd into master Aug 21, 2018
@ghost ghost removed the status/in-progress In progress label Aug 21, 2018
@mvdan mvdan deleted the kevina/extract branch July 1, 2021 16:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@kevina kevina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevina @Stebalien