feat: simplify pebble datastore creation with single set of options #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single set of options when creating the Pebble Datastore. One of the options allows passing a struct containing all Pebble options.This means that no argumants other than path are to create a pebble datastore with the default settings. Make it easier to handle creation/teardown of a custom-sized Pebble shared block cache. Only the cache size need to be specified as a creation option if using other the default size.
gammazero
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 2, 2024
Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1. There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any that are not configured or are set to the parameter's zero-value. Requires ipfs/go-ds-pebble#39 Closes #10347
|
Lotus does not use pebble so LGTM from my side. |
lidel
added a commit
to lidel/ipfs-cluster
that referenced
this pull request
Oct 3, 2024
Testing ipfs/go-ds-pebble#39 before tagging final release
lidel
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Tested in ipfs-cluster/ipfs-cluster#2099 and it should not cause big issue for existing users. Let's ship.
@gammazero mind merging and releasing, and switching ipfs/kubo#10530 to release version, so we can take it for a spin in Kubo 0.31 RC1 (ipfs/kubo#10499)?
gammazero
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 3, 2024
* include pebble as built-in plugin Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1. There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any that are not configured or are set to the parameter's zero-value. Requires ipfs/go-ds-pebble#39 Closes #10347 * docs: remove mention of ipfs-ds-convert. Rationale: ipfs-inactive/ipfs-ds-convert#50 * docs: pebbleds profile * test: meaningful t0025-datastores.sh * Update config/init.go * Update docs/config.md * Do not hard-code zero values into pebble config
lidel
added a commit
to lidel/ipfs-cluster
that referenced
this pull request
Oct 3, 2024
Refactor due to ipfs/go-ds-pebble#39
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single set of options when creating the Pebble Datastore. One of the options allows passing a struct containing Pebble options. It is no longer necessary to pass
nilwhen using the default configuration.Make it easier to handle creation/teardown of a custom-sized Pebble shared block cache. Only the cache size needs to be specified as a creation option if using other the default size. Instead of requiring the caller to pass in a cache instance, and manage its lifetime, a
WithCacheSizeoption can pass the size and let the pebble Datastore manage the cache lifetime. Passing in a cache can optionally still be done.