Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Archive refactor #59

Merged
merged 6 commits into from
Jan 30, 2019
Merged

Archive refactor #59

merged 6 commits into from
Jan 30, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jan 24, 2019

Needs to happen for ipfs get coreapi refactor

Depends on ipfs/go-ipfs-files#4

@magik6k magik6k requested a review from schomatis as a code owner January 24, 2019 19:37
@ghost ghost assigned magik6k Jan 24, 2019
@ghost ghost added the status/in-progress In progress label Jan 24, 2019
@Stebalien
Copy link
Member

Does FileArchive actually belong in this package? Or should we move it to go-ipfs-files as a helper for the TarWriter. It doesn't appear to be dag specific anymore.

@magik6k
Copy link
Member Author

magik6k commented Jan 30, 2019

Does FileArchive actually belong in this package?

Yeah, it's a bit weird. Given that it is rather ipfs get specific (and doesn't appear to be used anywhere else), I'm going to move it to the command

@magik6k magik6k force-pushed the misc/archive-refactor branch from 7736729 to 428fc30 Compare January 30, 2019 15:31
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this package was, until recently, an internal of go-ipfs and nobody appears to be using DagArchive directly, LGTM.

@Stebalien Stebalien merged commit 0eb1ef8 into master Jan 30, 2019
@ghost ghost removed the status/in-progress In progress label Jan 30, 2019
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 25, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants